Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip cloning PR repository in case of no projects were changed #1040

Closed
wants to merge 1 commit into from
Closed

Skip cloning PR repository in case of no projects were changed #1040

wants to merge 1 commit into from

Conversation

cucxabong
Copy link
Contributor

Implement #967 with github/gitlab support at this time. Thank @cket because of #973 , it give me an idea on how atlantis works

@cucxabong cucxabong force-pushed the issue-967 branch 2 times, most recently from 1382d49 to 1620fbd Compare May 18, 2020 13:37
@codecov
Copy link

codecov bot commented May 18, 2020 •
edited
Loading

Codecov Report

Merging #1040 into master will decrease coverage by 0.79%.
The diff coverage is 30.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
- Coverage   71.49%   70.70%   -0.80%     
==========================================
  Files          67       67              
  Lines        5564     5632      +68     
==========================================
+ Hits         3978     3982       +4     
- Misses       1272     1333      +61     
- Partials      314      317       +3
Impacted Files Coverage Δ
cmd/server.go 79.72% <ø> (ø)
server/events/vcs/azuredevops_client.go 65.55% <0.00%> (-1.28%) ⬇️
server/events/vcs/bitbucketcloud/client.go 46.04% <0.00%> (-1.37%) ⬇️
server/events/vcs/bitbucketserver/client.go 34.83% <0.00%> (-0.81%) ⬇️
server/events/vcs/github_client.go 75.39% <0.00%> (-5.51%) ⬇️
server/events/vcs/gitlab_client.go 36.64% <0.00%> (-3.03%) ⬇️
server/events/vcs/not_configured_vcs_client.go 0.00% <0.00%> (ø)
server/events/vcs/proxy.go 0.00% <0.00%> (ø)
server/user_config.go 100.00% <ø> (ø)
server/events/project_command_builder.go 77.43% <18.18%> (-5.15%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25cd66d...dd8bbe9. Read the comment docs.

@cucxabong cucxabong force-pushed the issue-967 branch 2 times, most recently from 2f8cea4 to ac58845 Compare May 18, 2020 15:46
@lkysow lkysow added the feature New functionality/enhancement label May 19, 2020
@lkysow lkysow mentioned this pull request May 25, 2020
Closed
@cucxabong
Copy link
Contributor Author

@lkysow could you have sometime on this

@lkysow lkysow mentioned this pull request Aug 18, 2020
Merged
@lkysow
Copy link
Member

lkysow commented Aug 18, 2020

Closed by #1158. Thanks! I just made some small changes to your work.

@lkysow lkysow closed this Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature New functionality/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cucxabong @lkysow